Fix bogus error message for the path used to reference sub packages. #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub packages should ("must") always be referenced through the path of their base package instead of their own path (in case it differs). However, the dependency resolution code assume the opposite. Both way are now accepted, but referencing the sub package path directly results in a warning.
|
Thanks for your pull request, @s-ludwig! |
|
@wilzbach: Do you have an idea why the SemaphoreCI status is not being reported anymore? I'd probably switch back to making TravisCI the required test, since I couldn't see what's wrong. |
wilzbach
approved these changes
Jul 6, 2020
I don't know what went wrong. Maybe they retired their 1.0 offering (and switched fully to 2.0). |
wilzbach
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Fix bogus warning for non-path based dependencies. Introduced by #1974. * update version to v1.23.0-rc.1 Co-authored-by: Sönke Ludwig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub packages should ("must") always be referenced through the path of their base package instead of their own path (in case it differs). However, the dependency resolution code assume the opposite. Both way are now accepted, but referencing the sub package path directly results in a warning.